Skip to content

feat: Add Dutch (nl-NL) translations.json and update config.json #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pamelafox merged 1 commit into from
Nov 4, 2024
Merged

feat: Add Dutch (nl-NL) translations.json and update config.json #2115

pamelafox merged 1 commit into from
Nov 4, 2024

Conversation

@jeannotdamoiseaux
Copy link
Contributor

@jeannotdamoiseaux jeannotdamoiseaux commented Nov 4, 2024

Purpose

This update adds support for the Dutch language in the application. It includes translations of the user interface and labels to Dutch, enabling a more accessible experience for Dutch-speaking users.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[ X ] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[ X ] No

Type of change

[ ] Bugfix
[ X ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@jeannotdamoiseaux
Copy link
Contributor Author

jeannotdamoiseaux commented Nov 4, 2024

I encountered one test failure when running python -m pytest, but this issue appears unrelated to my changes.

The failing test is:
FAILED tests/test_prepdocslib_textsplitter.py::test_sentencetextsplitter_list_parse_and_split - assert 1 > 1

@jeannotdamoiseaux

This comment was marked as off-topic.

Sign in to view
@jeannotdamoiseaux
Copy link
Contributor Author

jeannotdamoiseaux commented Nov 4, 2024

@pamelafox Could you review this PR?

@pamelafox
Copy link
Collaborator

pamelafox commented Nov 4, 2024

@jeannotdamoiseaux Thanks for the PR! A few questions:

  1. I assume that you wrote these translations yourself, i.e. you're a native Dutch speaker
  2. Will you be available to translate strings in the future, i.e. can I tag you on PRs that add new Dutch strings? I don't know if I have any Dutch speaking colleagues, so we need to make sure we have a strategy to continue support for nl
  3. Can you provide a screenshot of the app working with nl? Sometimes folks have contributed strings but not actually confirmed that they worked in the app, so I want to make sure.

@jeannotdamoiseaux
Copy link
Contributor Author

jeannotdamoiseaux commented Nov 4, 2024 •
edited
Loading

@jeannotdamoiseaux Thanks for the PR! A few questions:

  1. I assume that you wrote these translations yourself, i.e. you're a native Dutch speaker
  2. Will you be available to translate strings in the future, i.e. can I tag you on PRs that add new Dutch strings? I don't know if I have any Dutch speaking colleagues, so we need to make sure we have a strategy to continue support for nl
  3. Can you provide a screenshot of the app working with nl? Sometimes folks have contributed strings but not actually confirmed that they worked in the app, so I want to make sure.
  1. Yes, I’m a native Dutch speaker and did these translations myself.
  2. Sure, feel free to tag me in future PRs! I’m available to assist with new Dutch translations.
  3. I’ll upload a screenshot demonstrating the app with Dutch translations by tomorrow.

@pamelafox
Copy link
Collaborator

pamelafox commented Nov 4, 2024

Great, tests are passing on CI, so I'll approve and merge once screenshot is available. Thanks so much!

@jeannotdamoiseaux
Copy link
Contributor Author

jeannotdamoiseaux commented Nov 4, 2024

Great, tests are passing on CI, so I'll approve and merge once screenshot is available. Thanks so much!

image

Does this look good to you?

@pamelafox
Copy link
Collaborator

pamelafox commented Nov 4, 2024

Great, thank you!

@pamelafox pamelafox merged commit 3447262 into Azure-Samples:main Nov 4, 2024
10 checks passed
@jeannotdamoiseaux
Copy link
Contributor Author

jeannotdamoiseaux commented Nov 4, 2024

Great, thank you!

Excellent, thank you! I appreciate it. I’ll have a few more PRs coming your way soon!

@jeannotdamoiseaux jeannotdamoiseaux deleted the nl-language-support branch December 4, 2024 15:37
hasithb pushed a commit to hasithb/azure-search-openai-demo that referenced this pull request Oct 19, 2025
@jeannotdamoiseaux
feat: Add Dutch (nl-NL) translations.json and update config.json (Azu…
fcb7ee6 
…re-Samples#2115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pamelafox pamelafox pamelafox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeannotdamoiseaux @pamelafox